-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix document #3765
Fix document #3765
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3765 +/- ##
============================================
+ Coverage 83.48% 83.52% +0.04%
- Complexity 2914 2915 +1
============================================
Files 452 452
Lines 8766 8765 -1
Branches 1664 1665 +1
============================================
+ Hits 7318 7321 +3
+ Misses 544 542 -2
+ Partials 904 902 -2
Continue to review full report at Codecov.
|
...t-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExitOutsideMain.kt
Outdated
Show resolved
Hide resolved
...t-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExitOutsideMain.kt
Outdated
Show resolved
Hide resolved
@@ -43,11 +43,11 @@ import org.jetbrains.kotlin.psi.psiUtil.allChildren | |||
* taken from: http://kotlinlang.org/docs/reference/coding-conventions.html#modifiers | |||
* | |||
* <noncompliant> | |||
* lateinit internal private val str: String | |||
* lateinit internal val str: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* lateinit internal val str: String | |
* lateinit internal var str: String |
* </noncompliant> | ||
* | ||
* <compliant> | ||
* private internal lateinit val str: String | ||
* internal lateinit val str: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* internal lateinit val str: String | |
* internal lateinit var str: String |
Thanks for the pr! I think that compile the snippets should not be too complex. But I'm not sure how much false positives we will have. |
I fix some documentation.
By the way, it would be nice if lint of non-compliant blocks and compliant blocks could also be checked in the ci process. At least itself
If possible, I will open it as a separate issue.