Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3765 +/- ##
============================================
+ Coverage 83.48% 83.52% +0.04%
- Complexity 2914 2915 +1
============================================
Files 452 452
Lines 8766 8765 -1
Branches 1664 1665 +1
============================================
+ Hits 7318 7321 +3
+ Misses 544 542 -2
+ Partials 904 902 -2
Continue to review full report at Codecov.
|
schalkms
approved these changes
May 12, 2021
BraisGabin
approved these changes
May 13, 2021
| * | ||
| * <noncompliant> | ||
| * lateinit internal private val str: String | ||
| * lateinit internal val str: String |
Member
There was a problem hiding this comment.
Suggested change
| * lateinit internal val str: String | |
| * lateinit internal var str: String |
| * | ||
| * <compliant> | ||
| * private internal lateinit val str: String | ||
| * internal lateinit val str: String |
Member
There was a problem hiding this comment.
Suggested change
| * internal lateinit val str: String | |
| * internal lateinit var str: String |
Member
|
Thanks for the pr! I think that compile the snippets should not be too complex. But I'm not sure how much false positives we will have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fix some documentation.
By the way, it would be nice if lint of non-compliant blocks and compliant blocks could also be checked in the ci process. At least itself
If possible, I will open it as a separate issue.