Use annotation to configure rules in rules-empty #3771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3771 +/- ##
=========================================
Coverage 83.52% 83.52%
Complexity 2915 2915
=========================================
Files 452 452
Lines 8765 8766 +1
Branches 1665 1665
=========================================
+ Hits 7321 7322 +1
Misses 542 542
Partials 902 902
Continue to review full report at Codecov.
|
chao2zhang
approved these changes
May 12, 2021
BraisGabin
reviewed
May 13, 2021
| @Suppress("unused") | ||
| @Configuration("Excludes all the overridden functions") | ||
| @Deprecated("Use `ignoreOverridden` instead") | ||
| private val ignoreOverriddenFunctions: Boolean by config(false) |
There was a problem hiding this comment.
No, it is used to generate the documentation for the deprecated config option. The configWithFallback even checks that the property is there to ensure there is no typo.
There was a problem hiding this comment.
Let's tackle deprecated configs in separate PRs. I have not yet merged #3621
schalkms
approved these changes
May 13, 2021
BraisGabin
approved these changes
May 14, 2021
cortinico
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This belongs to #3670 and replaces all configuration kdoc tags in rules-empty with annotations.