Skip to content

Use @Configuration for rules-errorprone #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2021
Merged

Conversation

chao2zhang
Copy link
Member

This belongs to #3670 and replaces all configuration kdoc tags in detekt-rules-errorprone with annotation.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #3772 (7a426b8) into main (21b7d7c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3772      +/-   ##
============================================
- Coverage     83.52%   83.51%   -0.02%     
+ Complexity     2915     2914       -1     
============================================
  Files           452      452              
  Lines          8765     8759       -6     
  Branches       1665     1665              
============================================
- Hits           7321     7315       -6     
  Misses          542      542              
  Partials        902      902              
Impacted Files Coverage Δ Complexity Δ
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 79.16% <100.00%> (-4.17%) 9.00 <0.00> (-1.00)
...rbosch/detekt/rules/bugs/ImplicitUnitReturnType.kt 81.48% <100.00%> (ø) 10.00 <0.00> (ø)
...tlab/arturbosch/detekt/rules/bugs/LateinitUsage.kt 89.47% <100.00%> (ø) 7.00 <0.00> (ø)
...ab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt 87.50% <100.00%> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b7d7c...7a426b8. Read the comment docs.

Copy link
Contributor

@marschwar marschwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete the description for LateInitUsage#excludeAnnotatedProperties and convert the configuration in ImplicitUnitReturnType

@chao2zhang
Copy link
Member Author

convert the configuration in ImplicitUnitReturnType

Ooops, the @configuration appears above the

@cortinico cortinico added this to the 1.18.0 milestone May 14, 2021
@chao2zhang chao2zhang merged commit 36bc5f5 into detekt:main May 16, 2021
@chao2zhang chao2zhang deleted the config2 branch May 16, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants