Skip to content

Avoid overlapping outputs #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021
Merged

Avoid overlapping outputs #3790

merged 1 commit into from
May 17, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 17, 2021

javadocJar & publishPluginJar output to the same file path, as did
sourcesJar & publishPluginJavaDocsJar, preventing Gradle's up-to-date
checks from working properly.

javadocJar & publishPluginJar output to the same file path, as did
sourcesJar & publishPluginJavaDocsJar, preventing Gradle's up-to-date
checks from working properly.
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #3790 (e901254) into main (2fbac45) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3790   +/-   ##
=========================================
  Coverage     83.51%   83.51%           
  Complexity     2914     2914           
=========================================
  Files           452      452           
  Lines          8758     8758           
  Branches       1665     1665           
=========================================
  Hits           7314     7314           
  Misses          542      542           
  Partials        902      902           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbac45...e901254. Read the comment docs.

@3flex 3flex merged commit 069cc27 into detekt:main May 17, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jul 8, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jul 8, 2021
@cortinico
Copy link
Member

When releasing 1.18.0-RC1 I noticed that this PR is blocking the release process.
Specifically the sources.jar and the javadoc.jar are missing for detekt-gradle-plugin.

Maven Central is not allowing the whole bundle to be published if those artifacts are missing.

Should we revert this change?

@schalkms
Copy link
Member

schalkms commented Jul 8, 2021

Should we revert this change?

I don't see an alternative.

cortinico added a commit that referenced this pull request Jul 8, 2021
@3flex
Copy link
Member Author

3flex commented Jul 9, 2021

I don't see an alternative.

I'd argue there's no reason to publish the plugin artifact to Maven Central anyway, since it's already published to the Gradle Plugin Portal.

That's probably why the two publishing methods provided by Gradle don't work well together in this case (overlapping outputs) since it's not a typical setup.

@cortinico
Copy link
Member

I'd argue there's no reason to publish the plugin artifact to Maven Central anyway, since it's already published to the Gradle Plugin Portal.

I'm unsure about the historical reason why detekt-gradle-plugin is on Central as well.

One thing to point out is that detekt-gradle-plugin relies on detekt-bom and a lot of other deps that are published on Central. So it sounds reasonable to me that we publish all of our artifacts to me on Central + we offer detekt-gradle-plugin as a convenience for Gradle users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants