-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use annotations to configure rules in detekt-rules-exceptions #3798
Use annotations to configure rules in detekt-rules-exceptions #3798
Conversation
- NumberFormatException | ||
- ParseException | ||
- MalformedURLException | ||
ignoredExceptionTypes: ['NumberFormatException', 'InterruptedException', 'ParseException', 'MalformedURLException'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is a problem for git diffs. It is already adressed in #3671
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @3flex in that issue, use multiline in all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you following up to multiline in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I am working on a fix for the mutliline issue.
Codecov Report
@@ Coverage Diff @@
## main #3798 +/- ##
============================================
- Coverage 83.41% 83.30% -0.11%
+ Complexity 2902 2900 -2
============================================
Files 453 453
Lines 8741 8735 -6
Branches 1664 1665 +1
============================================
- Hits 7291 7277 -14
- Misses 550 558 +8
Partials 900 900
Continue to review full report at Codecov.
|
- NumberFormatException | ||
- ParseException | ||
- MalformedURLException | ||
ignoredExceptionTypes: ['NumberFormatException', 'InterruptedException', 'ParseException', 'MalformedURLException'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @3flex in that issue, use multiline in all of them.
- NumberFormatException | ||
- ParseException | ||
- MalformedURLException | ||
ignoredExceptionTypes: ['NumberFormatException', 'InterruptedException', 'ParseException', 'MalformedURLException'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you following up to multiline in a separate PR?
This belongs to #3670 and replaces all configuration kdoc tags with annotations.