Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotations to configure rules in detekt-rules-exceptions #3798

Merged
merged 1 commit into from
May 22, 2021

Conversation

marschwar
Copy link
Contributor

This belongs to #3670 and replaces all configuration kdoc tags with annotations.

- NumberFormatException
- ParseException
- MalformedURLException
ignoredExceptionTypes: ['NumberFormatException', 'InterruptedException', 'ParseException', 'MalformedURLException']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is a problem for git diffs. It is already adressed in #3671

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @3flex in that issue, use multiline in all of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you following up to multiline in a separate PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am working on a fix for the mutliline issue.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #3798 (ebf0266) into main (693f4f3) will decrease coverage by 0.10%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3798      +/-   ##
============================================
- Coverage     83.41%   83.30%   -0.11%     
+ Complexity     2902     2900       -2     
============================================
  Files           453      453              
  Lines          8741     8735       -6     
  Branches       1664     1665       +1     
============================================
- Hits           7291     7277      -14     
- Misses          550      558       +8     
  Partials        900      900              
Impacted Files Coverage Δ Complexity Δ
...eptions/ThrowingExceptionsWithoutMessageOrCause.kt 90.47% <71.42%> (ø) 6.00 <5.00> (-1.00)
...tekt/rules/exceptions/TooGenericExceptionThrown.kt 61.90% <87.50%> (-33.10%) 2.00 <0.00> (-2.00)
...tekt/rules/exceptions/TooGenericExceptionCaught.kt 86.95% <91.66%> (-1.51%) 6.00 <2.00> (+1.00) ⬇️
.../exceptions/ExceptionRaisedInUnexpectedLocation.kt 93.33% <100.00%> (-0.79%) 8.00 <2.00> (ø)
...bosch/detekt/rules/exceptions/ReturnFromFinally.kt 84.37% <100.00%> (ø) 10.00 <0.00> (ø)
...osch/detekt/rules/exceptions/SwallowedException.kt 78.18% <100.00%> (ø) 19.00 <1.00> (ø)
...n/kotlin/io/github/detekt/report/html/HtmlUtils.kt 97.43% <0.00%> (-2.57%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693f4f3...ebf0266. Read the comment docs.

- NumberFormatException
- ParseException
- MalformedURLException
ignoredExceptionTypes: ['NumberFormatException', 'InterruptedException', 'ParseException', 'MalformedURLException']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @3flex in that issue, use multiline in all of them.

- NumberFormatException
- ParseException
- MalformedURLException
ignoredExceptionTypes: ['NumberFormatException', 'InterruptedException', 'ParseException', 'MalformedURLException']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you following up to multiline in a separate PR?

@BraisGabin BraisGabin merged commit 86522c2 into detekt:main May 22, 2021
@cortinico cortinico added this to the 1.18.0 milestone May 22, 2021
@marschwar marschwar deleted the annotations-rules-exceptions branch May 24, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants