Use multi line format for list options in config#3827
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3827 +/- ##
=========================================
Coverage 83.53% 83.54%
- Complexity 3120 3125 +5
=========================================
Files 456 456
Lines 8996 9011 +15
Branches 1753 1757 +4
=========================================
+ Hits 7515 7528 +13
Misses 565 565
- Partials 916 918 +2
Continue to review full report at Codecov.
|
59f4202 to
158ad0f
Compare
86d694b to
27ea847
Compare
schalkms
left a comment
There was a problem hiding this comment.
Is there anything else left to do besides handling the merge conflict?
c5b3e76 to
6f0d0c4
Compare
From my point of view this is ready. There may be objections to making such a change as part of a minor version though. |
| Configuration( | ||
| name = "rulesetconfig3", | ||
| description = "description rulesetconfig2", | ||
| defaultValue = "['first', 'se*cond']", |
There was a problem hiding this comment.
Not an issue, but just curious that if the asterisk is intended.
There was a problem hiding this comment.
Yes, it is. The asterisk has a special meaning in yaml and the value has to be enclosed in parentheses.
The next version is v1.18 after v1.17.1. Hence I think it's okay. |
This closes #3671 and generates default list option in multi line format.