Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move formatting rules to @Configuration #3847

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

chao2zhang
Copy link
Member

This is part of the effort in #3670 to convert KDoc tag to actual Kotlin annotation. In this PR, we have all individual formatting rules to adopt @Configuration.

Notes:

  • FormattingProvider still has ruleset level configuration that is not covered in this PR.
  • configWithAndroidVariants was added as it is not possible to use a custom transformer with the existing config utilities.

@chao2zhang chao2zhang added this to the 1.18.0 milestone May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #3847 (aa20a5c) into main (6d27655) will increase coverage by 0.08%.
The diff coverage is 88.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3847      +/-   ##
============================================
+ Coverage     83.58%   83.66%   +0.08%     
- Complexity     3110     3117       +7     
============================================
  Files           456      456              
  Lines          8931     8965      +34     
  Branches       1748     1746       -2     
============================================
+ Hits           7465     7501      +36     
  Misses          551      551              
+ Partials        915      913       -2     
Impacted Files Coverage Δ
...urbosch/detekt/formatting/EditorConfigConstants.kt 100.00% <ø> (ø)
...ekt/generator/collection/ConfigurationCollector.kt 77.89% <80.39%> (+1.99%) ⬆️
...b/arturbosch/detekt/api/internal/ConfigProperty.kt 100.00% <100.00%> (ø)
...detekt/formatting/wrappers/ArgumentListWrapping.kt 100.00% <100.00%> (+10.00%) ⬆️
...urbosch/detekt/formatting/wrappers/FinalNewline.kt 100.00% <100.00%> (ø)
...bosch/detekt/formatting/wrappers/ImportOrdering.kt 100.00% <100.00%> (ø)
...turbosch/detekt/formatting/wrappers/Indentation.kt 100.00% <100.00%> (ø)
...ch/detekt/formatting/wrappers/MaximumLineLength.kt 100.00% <100.00%> (+10.00%) ⬆️
...etekt/formatting/wrappers/ParameterListWrapping.kt 100.00% <100.00%> (+10.00%) ⬆️
...bosch/detekt/generator/collection/Configuration.kt 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d27655...aa20a5c. Read the comment docs.

@chao2zhang chao2zhang merged commit e1943a2 into detekt:main Jun 1, 2021
@chao2zhang chao2zhang deleted the ktlintconfig branch June 1, 2021 19:59
@cortinico cortinico added housekeeping Marker for housekeeping tasks and refactorings and removed housekeeping Marker for housekeeping tasks and refactorings labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants