Skip to content

Remove Extensions.getRootArea #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

cortinico
Copy link
Member

Extensions.getRootArea is deprecated and should be replaced with ComponentManager.getExtensionArea()

Moreover this will potentially address #3844

Fixes #3683

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jun 1, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3848 (8fddeab) into main (7638573) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3848      +/-   ##
============================================
- Coverage     83.58%   83.56%   -0.03%     
+ Complexity     3110     3108       -2     
============================================
  Files           456      456              
  Lines          8931     8931              
  Branches       1748     1748              
============================================
- Hits           7465     7463       -2     
- Misses          551      552       +1     
- Partials        915      916       +1     
Impacted Files Coverage Δ
...n/kotlin/io/github/detekt/parser/DetektPomModel.kt 58.82% <50.00%> (-11.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7638573...8fddeab. Read the comment docs.

Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I was about to take a look yesterday but I am glad that this is addressed already

@cortinico cortinico merged commit fff8632 into detekt:main Jun 1, 2021
@cortinico cortinico deleted the nc/cleanup-extension-point branch June 1, 2021 16:16
@cortinico cortinico added notable changes Marker for notable changes in the changelog and removed housekeeping Marker for housekeeping tasks and refactorings labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use Extensions.getRootArea()
3 participants