Remove Extensions.getRootArea - #3848
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3848 +/- ##
============================================
- Coverage 83.58% 83.56% -0.03%
+ Complexity 3110 3108 -2
============================================
Files 456 456
Lines 8931 8931
Branches 1748 1748
============================================
- Hits 7465 7463 -2
- Misses 551 552 +1
- Partials 915 916 +1
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Jun 1, 2021
picklebento
approved these changes
Jun 1, 2021
picklebento
left a comment
picklebento
left a comment
Member
There was a problem hiding this comment.
Thank you for doing this. I was about to take a look yesterday but I am glad that this is addressed already
cortinico
added
notable changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions.getRootAreais deprecated and should be replaced withComponentManager.getExtensionArea()Moreover this will potentially address #3844
Fixes #3683