Set apiVersion to 1.4#3852
Merged
cortinico merged 1 commit intodetekt:mainfrom Jun 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3852 +/- ##
============================================
+ Coverage 83.56% 83.64% +0.08%
- Complexity 3108 3115 +7
============================================
Files 456 456
Lines 8931 8965 +34
Branches 1748 1746 -2
============================================
+ Hits 7463 7499 +36
Misses 552 552
+ Partials 916 914 -2
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Jun 4, 2021
Member
BraisGabin
left a comment
There was a problem hiding this comment.
Should we add information about this in our compatibility table?
Member
Author
Yup I will do it as soon as we release 1.18.0 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the
apiVersionto1.4and forces us to use only stdlib methods that were included in the 1.4 version.Given that the usage of the 1.5 APIs is limited, I believe we can support this.
Fixes #3849