-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set apiVersion to 1.4 #3852
Set apiVersion to 1.4 #3852
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3852 +/- ##
============================================
+ Coverage 83.56% 83.64% +0.08%
- Complexity 3108 3115 +7
============================================
Files 456 456
Lines 8931 8965 +34
Branches 1748 1746 -2
============================================
+ Hits 7463 7499 +36
Misses 552 552
+ Partials 916 914 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add information about this in our compatibility table?
Yup I will do it as soon as we release 1.18.0 👍 |
This sets the
apiVersion
to1.4
and forces us to use only stdlib methods that were included in the 1.4 version.Given that the usage of the 1.5 APIs is limited, I believe we can support this.
Fixes #3849