Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set apiVersion to 1.4 #3852

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Set apiVersion to 1.4 #3852

merged 1 commit into from
Jun 5, 2021

Conversation

cortinico
Copy link
Member

This sets the apiVersion to 1.4 and forces us to use only stdlib methods that were included in the 1.4 version.

Given that the usage of the 1.5 APIs is limited, I believe we can support this.

Fixes #3849

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #3852 (74604b6) into main (fff8632) will increase coverage by 0.08%.
The diff coverage is 86.59%.

❗ Current head 74604b6 differs from pull request most recent head f93ef3d. Consider uploading reports for the commit f93ef3d to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3852      +/-   ##
============================================
+ Coverage     83.56%   83.64%   +0.08%     
- Complexity     3108     3115       +7     
============================================
  Files           456      456              
  Lines          8931     8965      +34     
  Branches       1748     1746       -2     
============================================
+ Hits           7463     7499      +36     
  Misses          552      552              
+ Partials        916      914       -2     
Impacted Files Coverage Δ
...urbosch/detekt/formatting/EditorConfigConstants.kt 100.00% <ø> (ø)
...turbosch/detekt/generator/printer/DetektPrinter.kt 0.00% <0.00%> (ø)
...n/io/github/detekt/report/sarif/RuleDescriptors.kt 28.57% <0.00%> (ø)
...ekt/generator/collection/ConfigurationCollector.kt 77.89% <80.39%> (+1.99%) ⬆️
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt 86.95% <100.00%> (ø)
...b/arturbosch/detekt/api/internal/ConfigProperty.kt 100.00% <100.00%> (ø)
...detekt/formatting/wrappers/ArgumentListWrapping.kt 100.00% <100.00%> (+10.00%) ⬆️
...urbosch/detekt/formatting/wrappers/FinalNewline.kt 100.00% <100.00%> (ø)
...bosch/detekt/formatting/wrappers/ImportOrdering.kt 100.00% <100.00%> (ø)
...turbosch/detekt/formatting/wrappers/Indentation.kt 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff8632...f93ef3d. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add information about this in our compatibility table?

@cortinico
Copy link
Member Author

Should we add information about this in our compatibility table?

Yup I will do it as soon as we release 1.18.0 👍

@cortinico cortinico merged commit c496724 into detekt:main Jun 5, 2021
@cortinico cortinico deleted the nc/api-lvl branch June 5, 2021 10:21
@cortinico cortinico added this to the 1.18.0 milestone Jul 9, 2021
@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use apiVersion to keep compatible with previous version Kotlin stdlib
3 participants