Skip to content

verify that no rule is configured with kdoc tags#3870

Merged
BraisGabin merged 2 commits into
detekt:mainfrom
marschwar:assert-no-config-by-kdoc
Jun 16, 2021
Merged

verify that no rule is configured with kdoc tags#3870
BraisGabin merged 2 commits into
detekt:mainfrom
marschwar:assert-no-config-by-kdoc

Conversation

@marschwar

Copy link
Copy Markdown
Contributor

Part of the #3670 clean up. This adds verification that no rule contains a @configuraiton kdoc element.

@codecov

codecov Bot commented Jun 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3870 (1149249) into main (5b2446d) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3870      +/-   ##
============================================
- Coverage     83.56%   83.49%   -0.07%     
+ Complexity     3114     3111       -3     
============================================
  Files           456      456              
  Lines          8974     8973       -1     
  Branches       1751     1751              
============================================
- Hits           7499     7492       -7     
- Misses          561      565       +4     
- Partials        914      916       +2     
Impacted Files Coverage Δ
...urbosch/detekt/generator/collection/RuleVisitor.kt 89.88% <80.00%> (-0.23%) ⬇️
...arturbosch/detekt/generator/collection/KDocTags.kt 67.50% <100.00%> (-14.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2446d...1149249. Read the comment docs.

@marschwar marschwar force-pushed the assert-no-config-by-kdoc branch from 61d74b4 to 2f546bf Compare June 14, 2021 06:05
Markus Schwarz and others added 2 commits June 15, 2021 13:20
@marschwar marschwar force-pushed the assert-no-config-by-kdoc branch from 2f546bf to 1149249 Compare June 15, 2021 11:21
@cortinico cortinico added this to the 1.18.0 milestone Jun 15, 2021
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Jun 16, 2021
@BraisGabin BraisGabin merged commit f9684df into detekt:main Jun 16, 2021
@marschwar marschwar deleted the assert-no-config-by-kdoc branch July 27, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants