Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline value class to stay compatible with Kotlin 1.4 API #3871

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

chao2zhang
Copy link
Member

96511d1 was causing CI to fail on trunk, as the @JvmInline value class is an API in Kotlin 1.5 and we just set the API version to be Kotlin 1.4.

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #3871 (95892f0) into main (008b432) will increase coverage by 4.88%.
The diff coverage is 90.98%.

❗ Current head 95892f0 differs from pull request most recent head 2d094e5. Consider uploading reports for the commit 2d094e5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3871      +/-   ##
============================================
+ Coverage     78.67%   83.56%   +4.88%     
- Complexity     2888     3114     +226     
============================================
  Files           473      456      -17     
  Lines          9309     8974     -335     
  Branches       1704     1751      +47     
============================================
+ Hits           7324     7499     +175     
+ Misses         1080      561     -519     
- Partials        905      914       +9     
Impacted Files Coverage Δ
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <ø> (ø)
...rturbosch/detekt/core/settings/EnvironmentAware.kt 72.22% <0.00%> (+9.06%) ⬆️
...urbosch/detekt/formatting/EditorConfigConstants.kt 100.00% <ø> (ø)
...kt/formatting/wrappers/AnnotationOnSeparateLine.kt 100.00% <ø> (ø)
...ch/detekt/formatting/wrappers/AnnotationSpacing.kt 100.00% <ø> (ø)
...rbosch/detekt/formatting/wrappers/ChainWrapping.kt 100.00% <ø> (ø)
...bosch/detekt/formatting/wrappers/CommentSpacing.kt 100.00% <ø> (ø)
...ch/detekt/formatting/wrappers/EnumEntryNameCase.kt 100.00% <ø> (ø)
...sch/detekt/formatting/wrappers/ModifierOrdering.kt 100.00% <ø> (ø)
...osch/detekt/formatting/wrappers/MultiLineIfElse.kt 100.00% <ø> (ø)
... and 376 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96511d1...2d094e5. Read the comment docs.

@schalkms schalkms merged commit 5b2446d into detekt:main Jun 14, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants