Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionalUnit: fix false positive when function initializer is Nothing type #3876

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

t-kameyama
Copy link
Contributor

Fixes #3864

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #3876 (9b2f923) into main (5b2446d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3876      +/-   ##
============================================
- Coverage     83.56%   83.55%   -0.01%     
- Complexity     3114     3117       +3     
============================================
  Files           456      456              
  Lines          8974     8976       +2     
  Branches       1751     1752       +1     
============================================
+ Hits           7499     7500       +1     
  Misses          561      561              
- Partials        914      915       +1     
Impacted Files Coverage Δ
...rbosch/detekt/rules/style/optional/OptionalUnit.kt 80.85% <50.00%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2446d...9b2f923. Read the comment docs.

@cortinico cortinico added this to the 1.18.0 milestone Jun 16, 2021
@schalkms schalkms merged commit 50008db into detekt:main Jun 16, 2021
@t-kameyama t-kameyama deleted the issue_3864 branch June 16, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptionalUnit false positive for Nothing return type
4 participants