Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MapGetWithNotNullAsserSpec to follow test convention #3878

Merged

Conversation

cortinico
Copy link
Member

Just found this test file that doesn't follow our naming convention. I'm renaming it.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #3878 (0bff47d) into main (5b2446d) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

❗ Current head 0bff47d differs from pull request most recent head 9cfea8a. Consider uploading reports for the commit 9cfea8a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3878      +/-   ##
============================================
- Coverage     83.56%   83.50%   -0.07%     
- Complexity     3114     3115       +1     
============================================
  Files           456      456              
  Lines          8974     9001      +27     
  Branches       1751     1757       +6     
============================================
+ Hits           7499     7516      +17     
- Misses          561      566       +5     
- Partials        914      919       +5     
Impacted Files Coverage Δ
...rbosch/detekt/rules/style/optional/OptionalUnit.kt 80.85% <50.00%> (-1.38%) ⬇️
...urbosch/detekt/generator/collection/RuleVisitor.kt 89.88% <80.00%> (-0.23%) ⬇️
...arturbosch/detekt/generator/collection/KDocTags.kt 67.50% <100.00%> (-14.56%) ⬇️
...n/kotlin/io/github/detekt/report/html/HtmlUtils.kt 98.00% <0.00%> (-2.00%) ⬇️
.../io/github/detekt/parser/KotlinEnvironmentUtils.kt 75.00% <0.00%> (+1.19%) ⬆️
...urbosch/detekt/rules/performance/SpreadOperator.kt 78.78% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2446d...9cfea8a. Read the comment docs.

@schalkms schalkms merged commit 158744f into detekt:main Jun 16, 2021
@schalkms schalkms added this to the 1.18.0 milestone Jun 16, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants