Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exclusion pattern for InvalidPackageDeclaration #3907

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

cortinico
Copy link
Member

Related to #3900
The exclusion pattern for InvalidPackageDeclaration is wrong and should be fixed to '**/*.kts'

@cortinico cortinico added this to the 1.18.0 milestone Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #3907 (75874ca) into main (66f20e7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 75874ca differs from pull request most recent head e724d9c. Consider uploading reports for the commit e724d9c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3907      +/-   ##
============================================
- Coverage     83.55%   83.53%   -0.02%     
- Complexity     3118     3119       +1     
============================================
  Files           456      456              
  Lines          8973     8995      +22     
  Branches       1746     1752       +6     
============================================
+ Hits           7497     7514      +17     
- Misses          564      565       +1     
- Partials        912      916       +4     
Impacted Files Coverage Δ
.../detekt/generator/printer/rulesetpage/Exclusion.kt 96.66% <100.00%> (ø)
...ls/src/main/kotlin/io/github/detekt/psi/KtFiles.kt 73.52% <0.00%> (-4.25%) ⬇️
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt 73.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f20e7...e724d9c. Read the comment docs.

@schalkms schalkms merged commit 44c1ef0 into detekt:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants