Skip to content

Avoid empty lines when running detekt with type resolution #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

marschwar
Copy link
Contributor

This relates to #3684 and solves the issue of empty lines when running detekt with type resolution.

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #3909 (ecae2c7) into main (44c1ef0) will increase coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3909      +/-   ##
============================================
+ Coverage     83.53%   83.55%   +0.02%     
  Complexity     3120     3120              
============================================
  Files           456      456              
  Lines          8996     9001       +5     
  Branches       1753     1753              
============================================
+ Hits           7515     7521       +6     
+ Misses          565      564       -1     
  Partials        916      916              
Impacted Files Coverage Δ
...io/gitlab/arturbosch/detekt/core/BindingContext.kt 30.43% <75.00%> (+24.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c1ef0...ecae2c7. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a test for this behavior in order to avoid this issue in the future?

@marschwar
Copy link
Contributor Author

I don't think there is much that can be tested here other than the MessageCollector itself.

@schalkms schalkms merged commit cd3836e into detekt:main Jun 27, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jun 27, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jul 8, 2021
@marschwar marschwar deleted the fix/remove-empty-lines branch July 27, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants