Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail with a meaningful error message for invalid boolean #3931

Merged

Conversation

marschwar
Copy link
Contributor

This fixes #3884.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3931 (b65151c) into main (40abc3f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3931      +/-   ##
============================================
- Coverage     83.44%   83.44%   -0.01%     
  Complexity     3149     3149              
============================================
  Files           456      456              
  Lines          9014     9016       +2     
  Branches       1754     1754              
============================================
+ Hits           7522     7523       +1     
- Misses          565      566       +1     
  Partials        927      927              
Impacted Files Coverage Δ
...b/arturbosch/detekt/core/config/CompositeConfig.kt 75.00% <100.00%> (+8.33%) ⬆️
...tlab/arturbosch/detekt/api/internal/PathFilters.kt 89.28% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40abc3f...b65151c. Read the comment docs.

@cortinico cortinico added this to the 1.18.0 milestone Jul 2, 2021
@marschwar marschwar force-pushed the fix/classcastexception-invalid-boolean branch from 8167cc6 to 9303ded Compare July 3, 2021 17:43
@marschwar marschwar force-pushed the fix/classcastexception-invalid-boolean branch from 9303ded to b65151c Compare July 7, 2021 20:03
@cortinico cortinico merged commit c849d22 into detekt:main Jul 18, 2021
@marschwar marschwar deleted the fix/classcastexception-invalid-boolean branch July 18, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants