Skip to content

Increase memory available to gradle integration test daemon#3938

Merged
schalkms merged 4 commits into
detekt:mainfrom
marschwar:fix/increase-ci-memory
Jul 6, 2021
Merged

Increase memory available to gradle integration test daemon#3938
schalkms merged 4 commits into
detekt:mainfrom
marschwar:fix/increase-ci-memory

Conversation

@marschwar

Copy link
Copy Markdown
Contributor

Trying to figure out why there is a OutOfMemoryError on the CI

@codecov

codecov Bot commented Jul 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3938 (f2f2007) into main (5048b8b) will not change coverage.
The diff coverage is n/a.

❗ Current head f2f2007 differs from pull request most recent head bbf3be8. Consider uploading reports for the commit bbf3be8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3938   +/-   ##
=========================================
  Coverage     83.44%   83.44%           
  Complexity     3149     3149           
=========================================
  Files           456      456           
  Lines          9014     9014           
  Branches       1754     1754           
=========================================
  Hits           7522     7522           
  Misses          565      565           
  Partials        927      927           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5048b8b...bbf3be8. Read the comment docs.

@marschwar marschwar force-pushed the fix/increase-ci-memory branch from ddc2e0e to bbf3be8 Compare July 5, 2021 21:11
@cortinico

Copy link
Copy Markdown
Member

Do we plan to merge this?

@marschwar marschwar changed the title Specify jvm memory limits in gradle.properties Increase memory available to gradle integration test daemon Jul 6, 2021
@marschwar

Copy link
Copy Markdown
Contributor Author

Just increasing the memory does not feel right, but it seems like the only option for the moment as it does not seem to be possible to run the gradle test kit runner without daemon.

Maybe this can bring some live to the discussion in #3778.

@marschwar marschwar marked this pull request as ready for review July 6, 2021 18:35
@marschwar

Copy link
Copy Markdown
Contributor Author

Do we plan to merge this?

But to answer your question. Yes, I would merge this for the time beeing.

@schalkms schalkms merged commit 40abc3f into detekt:main Jul 6, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jul 9, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jul 9, 2021
@marschwar marschwar deleted the fix/increase-ci-memory branch July 27, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants