[FunctionNaming] Revert annotations that are ignored by default#3948
Merged
BraisGabin merged 1 commit intodetekt:mainfrom Jul 13, 2021
Merged
[FunctionNaming] Revert annotations that are ignored by default#3948BraisGabin merged 1 commit intodetekt:mainfrom
BraisGabin merged 1 commit intodetekt:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3948 +/- ##
=========================================
Coverage 83.58% 83.58%
Complexity 3123 3123
=========================================
Files 456 456
Lines 9014 9014
Branches 1752 1752
=========================================
Hits 7534 7534
Misses 564 564
Partials 916 916
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jul 11, 2021
picklebento
approved these changes
Jul 12, 2021
BraisGabin
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #3944 and partially reverts #3892.
While I strongly believe that detekt should not tailor the defaults for specific frameworks, I also agree with @G00fY2 and @cortinico that this change should not have been a by-product of another unrelated PR.