Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FunctionNaming] Revert annotations that are ignored by default #3948

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

marschwar
Copy link
Contributor

@marschwar marschwar commented Jul 11, 2021

This resolves #3944 and partially reverts #3892.

While I strongly believe that detekt should not tailor the defaults for specific frameworks, I also agree with @G00fY2 and @cortinico that this change should not have been a by-product of another unrelated PR.

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #3948 (c20dba2) into main (d81d6a2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3948   +/-   ##
=========================================
  Coverage     83.58%   83.58%           
  Complexity     3123     3123           
=========================================
  Files           456      456           
  Lines          9014     9014           
  Branches       1752     1752           
=========================================
  Hits           7534     7534           
  Misses          564      564           
  Partials        916      916           
Impacted Files Coverage Δ
...b/arturbosch/detekt/rules/naming/FunctionNaming.kt 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81d6a2...c20dba2. Read the comment docs.

@BraisGabin BraisGabin merged commit b2f277c into detekt:main Jul 13, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jul 13, 2021
@cortinico cortinico changed the title Revert annotations that are ignored by default [FunctionNaming] Revert annotations that are ignored by default Jul 16, 2021
@marschwar marschwar deleted the fix/revert-default-config branch July 27, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider reverting the FunctionNaming defaults after 1.18.0-RC1
5 participants