-
-
Notifications
You must be signed in to change notification settings - Fork 823
Rename property in gradle plugin extension from input to source #3951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3951 +/- ##
============================================
- Coverage 83.58% 83.44% -0.14%
- Complexity 3123 3149 +26
============================================
Files 456 456
Lines 9014 9014
Branches 1752 1754 +2
============================================
- Hits 7534 7522 -12
- Misses 564 565 +1
- Partials 916 927 +11
Continue to review full report at Codecov.
|
schalkms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I favor this change compared to the old behavior.
|
Are we ok to merge this? |
This closes #3918
Since switching to
org.gradle.api.tasks.SourceTask, there is a difference how users would specify the input to be checked using the detekt extension vs. creating a custom task which seemed to have confused users.detekt { input = files( "src/main/kotlin", "gensrc/main/kotlin" ) }vs.