Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Android: add javac intermediates to classpath (#3867)" #3958

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

chao2zhang
Copy link
Member

Resolves #3952.

Intention

detektIntermediatesJavacJar has the input path as intermediates/javac/${variant.name}/classes, which may trigger unnecessary tasks to execute.

Tests

Ran detektBaselineMain detektBaselineTest and verified that assembleDebug or assembleRelease are not run.
https://scans.gradle.com/s/q3mpjdwkffxaa/timeline.

Future

Reverting the change for the time being.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #3958 (0f785c0) into main (0ad69d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3958   +/-   ##
=========================================
  Coverage     83.44%   83.44%           
  Complexity     3149     3149           
=========================================
  Files           456      456           
  Lines          9014     9014           
  Branches       1754     1754           
=========================================
  Hits           7522     7522           
  Misses          565      565           
  Partials        927      927           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad69d5...0f785c0. Read the comment docs.

@cortinico cortinico added this to the 1.18.0 milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating baseline with Detekt 1.18.0-RC1 + Kotlin 1.5.1 uses all remaining disk then fails
3 participants