Revert "Android: add javac intermediates to classpath (#3867)"#3958
Merged
schalkms merged 1 commit intodetekt:mainfrom Jul 16, 2021
Merged
Revert "Android: add javac intermediates to classpath (#3867)"#3958schalkms merged 1 commit intodetekt:mainfrom
schalkms merged 1 commit intodetekt:mainfrom
Conversation
This reverts commit 69749f6
Codecov Report
@@ Coverage Diff @@
## main #3958 +/- ##
=========================================
Coverage 83.44% 83.44%
Complexity 3149 3149
=========================================
Files 456 456
Lines 9014 9014
Branches 1754 1754
=========================================
Hits 7522 7522
Misses 565 565
Partials 927 927 Continue to review full report at Codecov.
|
cortinico
approved these changes
Jul 16, 2021
schalkms
approved these changes
Jul 16, 2021
This was referenced Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3952.
Intention
detektIntermediatesJavacJarhas the input path asintermediates/javac/${variant.name}/classes, which may trigger unnecessary tasks to execute.Tests
Ran
detektBaselineMain detektBaselineTestand verified thatassembleDebugorassembleReleaseare not run.https://scans.gradle.com/s/q3mpjdwkffxaa/timeline.
Future
Reverting the change for the time being.