Skip to content

Create rule set configurations in a safe way#3964

Merged
picklebento merged 10 commits intodetekt:mainfrom
picklebento:constant
Oct 13, 2021
Merged

Create rule set configurations in a safe way#3964
picklebento merged 10 commits intodetekt:mainfrom
picklebento:constant

Conversation

@picklebento
Copy link
Copy Markdown
Member

This resolves #3816.

Created ruleSetConfig function to move RuleSetProviders' configuration from kdoc to actual annotation class.
Note that list as the default value is not supported until we actually have a usecase.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2021

Codecov Report

Merging #3964 (122f3ee) into main (cbdb460) will increase coverage by 0.11%.
The diff coverage is 88.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3964      +/-   ##
============================================
+ Coverage     83.51%   83.63%   +0.11%     
- Complexity     3186     3188       +2     
============================================
  Files           461      462       +1     
  Lines          9095     9085      -10     
  Branches       1768     1762       -6     
============================================
+ Hits           7596     7598       +2     
+ Misses          570      565       -5     
+ Partials        929      922       -7     
Impacted Files Coverage Δ
...arturbosch/detekt/generator/collection/KDocTags.kt 100.00% <ø> (+37.50%) ⬆️
...t/generator/collection/RuleSetProviderCollector.kt 72.60% <84.00%> (+3.51%) ⬆️
...bosch/detekt/api/internal/RuleSetConfigProperty.kt 100.00% <100.00%> (ø)
...arturbosch/detekt/formatting/FormattingProvider.kt 100.00% <100.00%> (ø)
...lab/arturbosch/detekt/formatting/FormattingRule.kt 97.67% <100.00%> (ø)
...t/generator/printer/defaultconfig/ConfigPrinter.kt 92.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdb460...122f3ee. Read the comment docs.

Copy link
Copy Markdown
Contributor

@marschwar marschwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up. I really like your solution.

@BraisGabin BraisGabin added this to the 1.19.0 milestone Aug 10, 2021
@BraisGabin
Copy link
Copy Markdown
Member

Is there something blocking us to merge this? 3 approvals and all checks are green seems good to me.

@picklebento
Copy link
Copy Markdown
Member Author

I was hoping to get more reviews for subsequent commits. Let me merge since as this has been left open for a while.

@picklebento picklebento merged commit eb62de7 into detekt:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure rule sets in a safe way

5 participants