Create rule set configurations in a safe way #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3964 +/- ##
============================================
+ Coverage 83.51% 83.63% +0.11%
- Complexity 3186 3188 +2
============================================
Files 461 462 +1
Lines 9095 9085 -10
Branches 1768 1762 -6
============================================
+ Hits 7596 7598 +2
+ Misses 570 565 -5
+ Partials 929 922 -7
Continue to review full report at Codecov.
|
schalkms
reviewed
Jul 19, 2021
...src/main/kotlin/io/gitlab/arturbosch/detekt/generator/collection/RuleSetProviderCollector.kt
Show resolved
Hide resolved
...src/main/kotlin/io/gitlab/arturbosch/detekt/generator/collection/RuleSetProviderCollector.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/io/gitlab/arturbosch/detekt/generator/collection/RuleSetProviderCollector.kt
Show resolved
Hide resolved
schalkms
approved these changes
Jul 19, 2021
marschwar
approved these changes
Jul 20, 2021
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/RuleSetConfigProperty.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/io/gitlab/arturbosch/detekt/generator/collection/RuleSetProviderCollector.kt
Show resolved
Hide resolved
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/RuleSetConfigProperty.kt
Show resolved
Hide resolved
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/RuleSetConfigProperty.kt
Outdated
Show resolved
Hide resolved
…ernal/RuleSetConfigProperty.kt Co-authored-by: marschwar <marschwar@users.noreply.github.com>
cortinico
approved these changes
Aug 30, 2021
|
Is there something blocking us to merge this? 3 approvals and all checks are green seems good to me. |
|
I was hoping to get more reviews for subsequent commits. Let me merge since as this has been left open for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3816.
Created
ruleSetConfigfunction to moveRuleSetProviders' configuration from kdoc to actual annotation class.Note that list as the default value is not supported until we actually have a usecase.