EmptyDefaultConstructor false positive with expect and actual classes#3970
Merged
picklebento merged 6 commits intomainfrom Jul 27, 2021
Merged
EmptyDefaultConstructor false positive with expect and actual classes#3970picklebento merged 6 commits intomainfrom
picklebento merged 6 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3970 +/- ##
============================================
+ Coverage 83.48% 83.49% +0.01%
- Complexity 3159 3160 +1
============================================
Files 458 458
Lines 9047 9047
Branches 1759 1759
============================================
+ Hits 7553 7554 +1
- Misses 567 568 +1
+ Partials 927 925 -2
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jul 24, 2021
picklebento
approved these changes
Jul 26, 2021
Member
picklebento
left a comment
There was a problem hiding this comment.
Thank you for the clean up!
...les-empty/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/empty/EmptyDefaultConstructor.kt
Outdated
Show resolved
Hide resolved
picklebento
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3929
The actual fix is just the last commit. But I did a bit of cleanup in the tests of this rule first.