Skip to content

EmptyDefaultConstructor false positive with expect and actual classes#3970

Merged
picklebento merged 6 commits intomainfrom
fix-3929
Jul 27, 2021
Merged

EmptyDefaultConstructor false positive with expect and actual classes#3970
picklebento merged 6 commits intomainfrom
fix-3929

Conversation

@BraisGabin
Copy link
Copy Markdown
Member

@BraisGabin BraisGabin commented Jul 24, 2021

Fix #3929

The actual fix is just the last commit. But I did a bit of cleanup in the tests of this rule first.

@BraisGabin BraisGabin added this to the 1.18.0 milestone Jul 24, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 24, 2021

Codecov Report

Merging #3970 (7f9a6d5) into main (ce7bb32) will increase coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head 7f9a6d5 differs from pull request most recent head b6b3c66. Consider uploading reports for the commit b6b3c66 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3970      +/-   ##
============================================
+ Coverage     83.48%   83.49%   +0.01%     
- Complexity     3159     3160       +1     
============================================
  Files           458      458              
  Lines          9047     9047              
  Branches       1759     1759              
============================================
+ Hits           7553     7554       +1     
- Misses          567      568       +1     
+ Partials        927      925       -2     
Impacted Files Coverage Δ
...osch/detekt/rules/empty/EmptyDefaultConstructor.kt 80.00% <50.00%> (ø)
...b/arturbosch/detekt/rules/naming/FunctionNaming.kt 100.00% <100.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce7bb32...b6b3c66. Read the comment docs.

Copy link
Copy Markdown
Member

@picklebento picklebento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EmptyDefaultConstructor is false positive for expect class

3 participants