Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable more exception rules for detekt code base #3995

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

marschwar
Copy link
Contributor

This relates to #3993 and enables checks from the èxceptions`rule set

@marschwar marschwar force-pushed the boyscout/enable-exception-rules branch from 7b194ff to 3c30096 Compare August 1, 2021 17:10
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #3995 (fe721e9) into main (a4c4f26) will increase coverage by 0.03%.
The diff coverage is 81.81%.

❗ Current head fe721e9 differs from pull request most recent head 3c30096. Consider uploading reports for the commit 3c30096 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3995      +/-   ##
============================================
+ Coverage     83.49%   83.53%   +0.03%     
- Complexity     3160     3165       +5     
============================================
  Files           458      458              
  Lines          9047     9053       +6     
  Branches       1759     1761       +2     
============================================
+ Hits           7554     7562       +8     
+ Misses          568      564       -4     
- Partials        925      927       +2     
Impacted Files Coverage Δ
.../arturbosch/detekt/rules/naming/NoNameShadowing.kt 62.06% <0.00%> (+6.89%) ⬆️
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 83.33% <88.88%> (+3.33%) ⬆️
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 91.36% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c4f26...3c30096. Read the comment docs.

@marschwar marschwar added the housekeeping Marker for housekeeping tasks and refactorings label Aug 2, 2021
@BraisGabin BraisGabin added this to the 1.18.0 milestone Aug 7, 2021
@BraisGabin BraisGabin merged commit 2271906 into detekt:main Aug 7, 2021
@marschwar marschwar deleted the boyscout/enable-exception-rules branch January 22, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants