Skip to content

enable those rules from the style rule set that have not violation or obvious fixes #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marschwar
Copy link
Contributor

This enables those rules from the style rule set that had no or very few violations

@marschwar marschwar force-pushed the boyscout/enable-styles-rules-without-violations branch from 405d4d9 to c9f7974 Compare August 1, 2021 20:11
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #3998 (498b3d3) into main (3710da1) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3998      +/-   ##
============================================
- Coverage     83.55%   83.50%   -0.05%     
- Complexity     3179     3181       +2     
============================================
  Files           459      459              
  Lines          9085     9082       -3     
  Branches       1765     1766       +1     
============================================
- Hits           7591     7584       -7     
  Misses          564      564              
- Partials        930      934       +4     
Impacted Files Coverage Δ
...io/gitlab/arturbosch/detekt/core/KtFileModifier.kt 0.00% <0.00%> (ø)
.../detekt/metrics/processors/ProjectSLOCProcessor.kt 92.30% <0.00%> (-7.70%) ⬇️
...bosch/detekt/rules/complexity/LongParameterList.kt 87.75% <0.00%> (-2.05%) ⬇️
...rbosch/detekt/rules/complexity/TooManyFunctions.kt 97.40% <0.00%> (-1.32%) ⬇️
...itlab/arturbosch/detekt/rules/style/ReturnCount.kt 92.68% <0.00%> (-2.56%) ⬇️
...otlin/io/gitlab/arturbosch/detekt/api/CodeSmell.kt 64.70% <50.00%> (ø)
...t/rules/style/UtilityClassWithPublicConstructor.kt 93.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3710da1...498b3d3. Read the comment docs.

@marschwar marschwar added the housekeeping Marker for housekeeping tasks and refactorings label Aug 2, 2021
@cortinico cortinico added this to the 1.18.0 milestone Aug 2, 2021
@BraisGabin BraisGabin merged commit 53371a2 into detekt:main Aug 6, 2021
@marschwar marschwar deleted the boyscout/enable-styles-rules-without-violations branch August 6, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants