Skip to content

Enable UseOrEmpty for detekt code base #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

marschwar
Copy link
Contributor

This relates to #3993 and enables the UseOrEmpty rule which I did not know about and really like.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #3999 (e12962e) into main (53371a2) will increase coverage by 0.03%.
The diff coverage is 36.36%.

❗ Current head e12962e differs from pull request most recent head 7e53c58. Consider uploading reports for the commit 7e53c58 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3999      +/-   ##
============================================
+ Coverage     83.51%   83.54%   +0.03%     
- Complexity     3177     3179       +2     
============================================
  Files           459      459              
  Lines          9081     9081              
  Branches       1765     1772       +7     
============================================
+ Hits           7584     7587       +3     
+ Misses          564      560       -4     
- Partials        933      934       +1     
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/api/AnnotationExcluder.kt 66.66% <0.00%> (ø)
...itlab/arturbosch/detekt/api/internal/Signatures.kt 76.59% <0.00%> (ø)
...b/arturbosch/detekt/core/reporting/OutputFacade.kt 84.21% <0.00%> (ø)
...ekt/generator/collection/DocumentationCollector.kt 85.00% <0.00%> (ø)
.../detekt/generator/collection/MultiRuleCollector.kt 73.77% <0.00%> (ø)
...t/generator/collection/RuleSetProviderCollector.kt 69.09% <0.00%> (ø)
...etekt/rules/coroutines/RedundantSuspendModifier.kt 59.52% <0.00%> (ø)
.../gitlab/arturbosch/detekt/rules/bugs/UnsafeCast.kt 81.25% <0.00%> (ø)
...b/arturbosch/detekt/rules/style/ForbiddenImport.kt 95.00% <0.00%> (ø)
...itlab/arturbosch/detekt/rules/style/ReturnCount.kt 92.68% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53371a2...7e53c58. Read the comment docs.

@marschwar marschwar added the housekeeping Marker for housekeeping tasks and refactorings label Aug 2, 2021
@cortinico cortinico added this to the 1.18.0 milestone Aug 2, 2021
@cortinico cortinico merged commit 458e786 into detekt:main Aug 6, 2021
@marschwar marschwar deleted the boyscout/enable-orEmpty branch August 6, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants