-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort config lists #4014
Sort config lists #4014
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4014 +/- ##
=========================================
Coverage 83.55% 83.56%
Complexity 3181 3181
=========================================
Files 459 459
Lines 9085 9090 +5
Branches 1771 1771
=========================================
+ Hits 7591 7596 +5
Misses 561 561
Partials 933 933
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. We would have to pay attention. Every PR could change the alphabetical order. I don't think this would improve anything.
I was thinking about the same. Perhaps we should consider adding some pre-commit hooks or PR checks that verifies the YAML files? |
A pre-commit hook doesn't help much, since every contributor needs to configure the hook on the local machine. |
Completely agree. This is easy to be broken. I do this change just because we are changing all those lines anyway so, at least, have an alphabetical order for some configurations that, usually, doesn't change. For me the check/unit test is not worth it. I vote to merge because this lines will be changed for all our users anyway. And if a next change "breaks" the order... well, that's not a big deal. |
1b469f2
to
f622d26
Compare
In this release we are already changing our default config yaml. For that reason I think that we could use it to sort the list configurations to follow an alphabetic order. I sorted all of them but I'm not sure if it have sense to do it with all of them because maybe there is another "more logical order". These are the rules that maybe a "more logical order" can exist: