Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseDataClass: fix false positive on value classes #4016

Merged
merged 2 commits into from
Aug 7, 2021

Conversation

cortinico
Copy link
Member

Fixes #4010

@cortinico cortinico added this to the 1.18.0 milestone Aug 7, 2021
@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #4016 (fdafabc) into main (2271906) will increase coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head fdafabc differs from pull request most recent head 02ada28. Consider uploading reports for the commit 02ada28 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4016      +/-   ##
============================================
+ Coverage     83.53%   83.55%   +0.01%     
- Complexity     3179     3181       +2     
============================================
  Files           459      459              
  Lines          9082     9083       +1     
  Branches       1772     1771       -1     
============================================
+ Hits           7587     7589       +2     
  Misses          561      561              
+ Partials        934      933       -1     
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/generator/out/Markdown.kt 21.42% <0.00%> (ø)
.../io/gitlab/arturbosch/detekt/generator/out/Yaml.kt 68.57% <0.00%> (ø)
...rbosch/detekt/rules/bugs/ImplicitUnitReturnType.kt 86.66% <66.66%> (+3.33%) ⬆️
...tlab/arturbosch/detekt/rules/style/UseDataClass.kt 77.94% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2271906...02ada28. Read the comment docs.

@BraisGabin BraisGabin merged commit 8abb138 into detekt:main Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UseDataClass triggers on value classes
5 participants