Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UnnecessaryLet rule for detekt code base #4024

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

marschwar
Copy link
Contributor

Yet another one

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #4024 (3d6f92c) into main (48c1da8) will increase coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4024   +/-   ##
=========================================
  Coverage     83.55%   83.55%           
- Complexity     3181     3182    +1     
=========================================
  Files           459      459           
  Lines          9085     9087    +2     
  Branches       1771     1771           
=========================================
+ Hits           7591     7593    +2     
  Misses          561      561           
  Partials        933      933           
Impacted Files Coverage Δ
...n/io/github/detekt/metrics/CyclomaticComplexity.kt 94.44% <0.00%> (ø)
...rbosch/detekt/rules/complexity/NestedBlockDepth.kt 91.83% <0.00%> (ø)
...tlab/arturbosch/detekt/rules/naming/NamingRules.kt 93.65% <0.00%> (ø)
...lab/arturbosch/detekt/api/internal/Suppressions.kt 74.07% <100.00%> (+0.99%) ⬆️
...ules/documentation/LicenceHeaderLoaderExtension.kt 80.95% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c1da8...3d6f92c. Read the comment docs.

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Aug 9, 2021
@BraisGabin BraisGabin added this to the 1.18.0 milestone Aug 10, 2021
@BraisGabin BraisGabin merged commit 28830b8 into detekt:main Aug 10, 2021
@marschwar marschwar deleted the enable-UnnecessaryLet branch August 10, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants