[KMP] Fix resolution of Android test classpaths #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
force-pushed
the
nc/fix-android-kmp
branch
from
d4b89be
to
9491c10
Compare
Codecov Report
@@ Coverage Diff @@
## main #4026 +/- ##
=========================================
Coverage 83.56% 83.56%
Complexity 3182 3182
=========================================
Files 459 459
Lines 9092 9092
Branches 1771 1771
=========================================
Hits 7598 7598
Misses 561 561
Partials 933 933 Continue to review full report at Codecov.
|
chao2zhang
reviewed
Aug 9, 2021
...kt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/internal/DetektMultiplatform.kt
Show resolved
Hide resolved
We're already on AGP |
BraisGabin
approved these changes
Aug 11, 2021
cortinico
force-pushed
the
nc/fix-android-kmp
branch
from
9491c10
to
6234a79
Compare
chao2zhang
approved these changes
Aug 11, 2021
|
There is a |
cortinico
force-pushed
the
nc/fix-android-kmp
branch
from
2c0fa3b
to
25d3edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #4025
The approach used inside the KMP support for
detekt-gradle-pluginwas not working correctly for tests sourcesets of Android targets. I fixed it by delegating the creation of detekt tasks forandroid()targets toDetektAndroid. This will also make sure that the behavior between a pure Android project and a KMP project with an Android target is closer.Fixes #3840