Fix TextLocation of Indentation rule#4030
Merged
schalkms merged 3 commits intodetekt:mainfrom Aug 13, 2021
Merged
Conversation
Although Indentation applies to the whole file, it's a local rule. Start of the real location reported by ktlint's offset. And I assume that the end location should be on first non-whitespace character.
Codecov Report
@@ Coverage Diff @@
## main #4030 +/- ##
============================================
+ Coverage 83.54% 83.57% +0.02%
- Complexity 3180 3186 +6
============================================
Files 459 459
Lines 9082 9097 +15
Branches 1770 1772 +2
============================================
+ Hits 7588 7603 +15
Misses 561 561
Partials 933 933
Continue to review full report at Codecov.
|
schalkms
reviewed
Aug 11, 2021
Member
schalkms
left a comment
There was a problem hiding this comment.
Awesome 1st contribution! Thank you for that.
The code changes look fine to me. In my opinion, a test should be added in order to avoid this issue in the future.
Contributor
Author
|
Great idea! I will add test for that |
schalkms
approved these changes
Aug 13, 2021
This was referenced Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although Indentation applies to the whole file, it's a local rule. Start of the real location reported by ktlint's offset. And I assume that the end location should be on first non-whitespace character.
This cause detekt plugin to highlight the whole file and html output to highlight everything to the end of snippet.
Relevant issue: detekt/detekt-intellij-plugin#131