Fix issue IDs for ReferentialEquality and DoubleMutability

[geojakes]

Trying to fix for #4039
I think the issue ID created does not match the configuration and hence does not affect it the same way as expected.

Disabling the DoubleMutabilityForCollection rule as it seems the project has quite a few of said issues

[schalkms]

Thanks for the fix! I guess this strings were forgotten during the rule refactoring.

[codecov]

Codecov Report

Merging #4040 (c472dbe) into main (31106ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #4040   +/-   ##
=========================================
  Coverage     83.56%   83.57%           
- Complexity     3182     3186    +4     
=========================================
  Files           459      459           
  Lines          9092     9097    +5     
  Branches       1771     1772    +1     
=========================================
+ Hits           7598     7603    +5     
  Misses          561      561           
  Partials        933      933           

Impacted Files	Coverage Δ
.../kotlin/io/gitlab/arturbosch/detekt/api/Context.kt	70.00% <100.00%> (ø)
...osch/detekt/rules/bugs/AvoidReferentialEquality.kt	91.30% <100.00%> (ø)
...detekt/rules/bugs/DoubleMutabilityForCollection.kt	88.46% <100.00%> (ø)
...turbosch/detekt/formatting/wrappers/Indentation.kt	100.00% <0.00%> (ø)
...lab/arturbosch/detekt/formatting/FormattingRule.kt	97.67% <0.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31106ff...c472dbe. Read the comment docs.

[geojakes]

@schalkms Np! :) How do I get this merged?

[schalkms]

@geojakes I think the following issue needs to be fixed. Then this PR is ready to be merged.

DoubleMutabilityForCollection - [_findings] at /home/runner/work/detekt/detekt/detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Context.kt:53:5

[geojakes]

@schalkms Looks like that's unrelated to the PR since that area isn't being touched at all. I ran a detektMain and detektTest on the repo, seems like there are many more locations with the same issue

[geojakes]

@schalkms Made the relevant changes to that specific file though

[schalkms]

Looks like that's unrelated to the PR since that area isn't being touched at all. I ran a detektMain and detektTest on the repo, seems like there are many more locations with the same issue

Yes, this is kind of unrelated to this PR. However, the fixed rule now yields errors for the detekt codebase, since detekt's static analysis capability is applied to itself. This approach is also called dogfooding.

[geojakes]

@schalkms Looks like once that is fixed, it yielded more errors

potential-bugs - 15min debt
	DoubleMutabilityForCollection - [classesMap] at /home/runner/work/detekt/detekt/detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/collection/MultiRuleCollector.kt:42:5
	DoubleMutabilityForCollection - [ruleNames] at /home/runner/work/detekt/detekt/detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/collection/MultiRuleCollector.kt:105:5
	DoubleMutabilityForCollection - [ruleProperties] at /home/runner/work/detekt/detekt/detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/collection/MultiRuleCollector.kt:107:5

These look a little more complicated to fix. Maybe we should turn this rule off and open a new issue to address the same?

[geojakes]

Updated to disable the rule, adding a new issue to fix the same: #4042

[geojakes]

Looks like this scan is broken in the main branch as well...

[BraisGabin]

Good catch! But... This seems like an issue in the config generation... We should use the issue name, no the class name.

[geojakes]

@BraisGabin I somehow get weird outputs from the repo. When I apply my fix, it picks up the DoubleMutability issues, but does allow me to deactivate it from the config. On the other hand, another project that I work on, runs 1.18.0, picks up the DoubleMutability issue, but does not allow deactivation via config. Is this because of how detekt does its dogfooding?

[BraisGabin]

No, no, your fix is perfect. But I think that we could fix the generator to prevent this kind of issues. But that's another topic.

[geojakes]

@schalkms @BraisGabin Does this look okay to merge?

[BraisGabin]

It does.

[geojakes]

@BraisGabin What is the process for a micro version release?

[BraisGabin]

There is not a defined process or ETA. But this kind of fix versions are released "fast"