Skip to content

Conversation

@BraisGabin
Copy link
Member

in 1.17.1 the rule set comments had the excludes flag on it. But we removed it from there and lowered to some of their rules. Now, the old configurations of our users are complainig about it. This bug was there for long time but no one notices until now.

Fix #4038

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #4045 (2d249c2) into main (deb39b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4045   +/-   ##
=========================================
  Coverage     83.57%   83.58%           
  Complexity     3186     3186           
=========================================
  Files           459      459           
  Lines          9097     9100    +3     
  Branches       1772     1772           
=========================================
+ Hits           7603     7606    +3     
  Misses          561      561           
  Partials        933      933           
Impacted Files Coverage Δ
...sch/detekt/core/config/ValidatableConfiguration.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb39b3...2d249c2. Read the comment docs.

@chao2zhang chao2zhang added this to the 1.18.1 milestone Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Property 'comments>excludes' is misspelled or does not exist" with detekt 1.18.0

5 participants