Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4056 +/- ##
=========================================
Coverage 83.58% 83.58%
Complexity 3186 3186
=========================================
Files 459 459
Lines 9099 9099
Branches 1772 1772
=========================================
Hits 7605 7605
Misses 561 561
Partials 933 933 Continue to review full report at Codecov.
|
picklebento
approved these changes
Aug 19, 2021
| [plugins] | ||
| binaryCompatibilityValidator = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version = "0.4.0" } | ||
| dokka = { id = "org.jetbrains.dokka", version.ref = "dokka" } | ||
| gradleVersionz = { id = "com.github.ben-manes.versions", version = "0.28.0" } |
Member
There was a problem hiding this comment.
Is z a typo or just to prevent naming clash?
Member
Author
There was a problem hiding this comment.
"versions" isn't permitted as a suffix unfortunately (nor "version").
Happy for other suggestions? It can't end with "plugin" either.
BraisGabin
approved these changes
Aug 19, 2021
cortinico
approved these changes
Aug 20, 2021
marschwar
reviewed
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also takes advantage of enhancements to version catalogs available in the new version.