Skip to content

Upscale JVM settings#4057

Merged
picklebento merged 1 commit intodetekt:mainfrom
picklebento:gradle
Aug 19, 2021
Merged

Upscale JVM settings#4057
picklebento merged 1 commit intodetekt:mainfrom
picklebento:gradle

Conversation

@picklebento
Copy link
Copy Markdown
Member

There are recent instances of out out memory error, such as:

This PR doubles the default configuration for building the project.
As the default JVM arguments from Gradle is Xmx512m "-XX:MaxMetaspaceSize=256m" (https://docs.gradle.org/current/userguide/build_environment.html#sec:configuring_jvm_memory)

There is not an easy way to verify that this will work (Unless we kick-off hundreds of github action jobs to verify the volume of OOM build errors is reduced). But I would believe this is a reasonable first step.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2021

Codecov Report

Merging #4057 (518ab1a) into main (48c1da8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4057      +/-   ##
============================================
+ Coverage     83.55%   83.58%   +0.02%     
- Complexity     3181     3186       +5     
============================================
  Files           459      459              
  Lines          9085     9099      +14     
  Branches       1771     1772       +1     
============================================
+ Hits           7591     7605      +14     
  Misses          561      561              
  Partials        933      933              
Impacted Files Coverage Δ
...eptions/ThrowingExceptionsWithoutMessageOrCause.kt 91.30% <0.00%> (-0.37%) ⬇️
.../io/gitlab/arturbosch/detekt/api/ConfigProperty.kt 100.00% <0.00%> (ø)
...sch/detekt/core/config/ValidatableConfiguration.kt 100.00% <0.00%> (ø)
...turbosch/detekt/formatting/wrappers/Indentation.kt 100.00% <0.00%> (ø)
...rturbosch/detekt/rules/empty/EmptyFunctionBlock.kt 93.33% <0.00%> (ø)
...sch/detekt/rules/naming/FunctionParameterNaming.kt 90.90% <0.00%> (ø)
...bosch/detekt/rules/complexity/LongParameterList.kt 87.75% <0.00%> (ø)
...h/detekt/rules/naming/MemberNameEqualsClassName.kt 84.21% <0.00%> (ø)
...lab/arturbosch/detekt/formatting/FormattingRule.kt 97.67% <0.00%> (+0.05%) ⬆️
...ules/documentation/LicenceHeaderLoaderExtension.kt 80.95% <0.00%> (+0.46%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c1da8...518ab1a. Read the comment docs.

@picklebento picklebento merged commit 0721351 into detekt:main Aug 19, 2021
@cortinico cortinico added this to the 1.19.0 milestone Oct 31, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants