Skip to content

Fix confusing message when breaking the MultilineLambdaItParameter rule#4089

Merged
schalkms merged 1 commit into
detekt:mainfrom
ngsconstruction:fixMultilineLambdaTypo
Sep 3, 2021
Merged

Fix confusing message when breaking the MultilineLambdaItParameter rule#4089
schalkms merged 1 commit into
detekt:mainfrom
ngsconstruction:fixMultilineLambdaTypo

Conversation

@ngsconstruction

Copy link
Copy Markdown
Contributor

Previously, this message essentially suggested doing what the offending code would already be doing, which is using the implicit it in a multiline lambda expression.

@codecov

codecov Bot commented Sep 3, 2021

Copy link
Copy Markdown

Codecov Report

Merging #4089 (bd76708) into main (4053bb7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bd76708 differs from pull request most recent head c77391e. Consider uploading reports for the commit c77391e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4089   +/-   ##
=========================================
  Coverage     83.58%   83.58%           
  Complexity     3187     3187           
=========================================
  Files           459      459           
  Lines          9101     9101           
  Branches       1772     1772           
=========================================
  Hits           7607     7607           
  Misses          561      561           
  Partials        933      933           
Impacted Files Coverage Δ
...h/detekt/rules/style/MultilineLambdaItParameter.kt 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4053bb7...c77391e. Read the comment docs.

@schalkms schalkms merged commit 5081b89 into detekt:main Sep 3, 2021
@cortinico cortinico added this to the 1.19.0 milestone Sep 4, 2021
@cortinico cortinico added the rules label Sep 4, 2021
@ngsconstruction ngsconstruction deleted the fixMultilineLambdaTypo branch September 17, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants