Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4098 +/- ##
============================================
- Coverage 83.58% 83.51% -0.08%
- Complexity 3187 3192 +5
============================================
Files 459 460 +1
Lines 9101 9109 +8
Branches 1772 1773 +1
============================================
Hits 7607 7607
- Misses 561 569 +8
Partials 933 933
Continue to review full report at Codecov.
|
08f39d2 to
6c6f224
Compare
marschwar
approved these changes
Sep 14, 2021
cortinico
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just copy&paste the
DefaultContextclass in api.internal so we can use it and I deprecated the "public" one. We don't need to expose this. If someone wants to change the behaviour can implementContextdirectly.