Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DefaultContext #4098

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Deprecate DefaultContext #4098

merged 1 commit into from
Sep 14, 2021

Conversation

BraisGabin
Copy link
Member

I just copy&paste the DefaultContext class in api.internal so we can use it and I deprecated the "public" one. We don't need to expose this. If someone wants to change the behaviour can implement Context directly.

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #4098 (86a9e8c) into main (e0aed91) will decrease coverage by 0.07%.
The diff coverage is 75.00%.

❗ Current head 86a9e8c differs from pull request most recent head 6c6f224. Consider uploading reports for the commit 6c6f224 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4098      +/-   ##
============================================
- Coverage     83.58%   83.51%   -0.08%     
- Complexity     3187     3192       +5     
============================================
  Files           459      460       +1     
  Lines          9101     9109       +8     
  Branches       1772     1773       +1     
============================================
  Hits           7607     7607              
- Misses          561      569       +8     
  Partials        933      933              
Impacted Files Coverage Δ
.../kotlin/io/gitlab/arturbosch/detekt/api/Context.kt 9.09% <0.00%> (-60.91%) ⬇️
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt 65.21% <ø> (ø)
.../gitlab/arturbosch/detekt/api/internal/BaseRule.kt 100.00% <ø> (ø)
...b/arturbosch/detekt/api/internal/DefaultContext.kt 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0aed91...6c6f224. Read the comment docs.

@BraisGabin BraisGabin changed the title Deprecated DefaultContext Deprecate DefaultContext Sep 13, 2021
@BraisGabin BraisGabin added this to the 1.19.0 milestone Sep 14, 2021
@BraisGabin BraisGabin merged commit 19b06c9 into main Sep 14, 2021
@BraisGabin BraisGabin deleted the deprecate-default-context branch September 14, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants