Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnnecessaryAbstractClass: false positive when the abstract class has internal/protected abstract members #4099

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

t-kameyama
Copy link
Contributor

Fixes #4093

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #4099 (108395a) into main (e0aed91) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4099      +/-   ##
============================================
+ Coverage     83.58%   83.60%   +0.01%     
  Complexity     3187     3187              
============================================
  Files           459      459              
  Lines          9101     9098       -3     
  Branches       1772     1769       -3     
============================================
- Hits           7607     7606       -1     
+ Misses          561      560       -1     
+ Partials        933      932       -1     
Impacted Files Coverage Δ
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 85.36% <80.00%> (+1.27%) ⬆️
...o/gitlab/arturbosch/detekt/rules/KtModifierList.kt 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0aed91...108395a. Read the comment docs.

@BraisGabin BraisGabin merged commit 465ccdd into detekt:main Sep 13, 2021
@BraisGabin BraisGabin added this to the 1.19.0 milestone Sep 13, 2021
@t-kameyama t-kameyama deleted the issue_4093 branch September 13, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in UnnecessaryAbstractClass
3 participants