Skip to content

Remove library specific configurations #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

BraisGabin
Copy link
Member

We don't want to have library specific configurations in the default configuration of detekt. There are far too much libraries out there for us to keep their configuration. For historical reasons we had 4 configurations that were "violating" this rule. This PR fixes that.

Related: #3894, #3041, #2747, #3944

@BraisGabin BraisGabin force-pushed the remove-library-specific-configurations branch from 507b722 to 2dfd7d1 Compare September 11, 2021 14:04
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #4101 (2dfd7d1) into main (e0aed91) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4101      +/-   ##
============================================
- Coverage     83.58%   83.57%   -0.01%     
  Complexity     3187     3187              
============================================
  Files           459      459              
  Lines          9101     9097       -4     
  Branches       1772     1772              
============================================
- Hits           7607     7603       -4     
  Misses          561      561              
  Partials        933      933              
Impacted Files Coverage Δ
...b/arturbosch/detekt/rules/naming/FunctionNaming.kt 100.00% <100.00%> (ø)
...etekt/rules/style/FunctionOnlyReturningConstant.kt 97.43% <100.00%> (ø)
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 84.09% <100.00%> (ø)
...ab/arturbosch/detekt/rules/style/WildcardImport.kt 90.00% <100.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0aed91...2dfd7d1. Read the comment docs.

@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Sep 13, 2021
@cortinico cortinico added this to the 1.19.0 milestone Sep 13, 2021
@BraisGabin BraisGabin merged commit 9bb1e22 into main Sep 14, 2021
@BraisGabin BraisGabin deleted the remove-library-specific-configurations branch September 14, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants