Skip to content

Rename and split ValidateConfig files #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

BraisGabin
Copy link
Member

The important part of the old file ValidatableConfiguration.kt wasn't the interface. It was the function validateConfig. And for that reason the tests were difficult to find.

With this PR I move the interface ValidatableConfiguration to its own file (it's not THAT related with validateConfig. And I create the file ValidateConfig.kt for the funcition validateConfig and its helpers. I rename the tests file to ValidateConfigSpec.kt to make it easier to find.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Sep 11, 2021
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #4105 (6421e90) into main (e0aed91) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4105   +/-   ##
=========================================
  Coverage     83.58%   83.58%           
  Complexity     3187     3187           
=========================================
  Files           459      459           
  Lines          9101     9101           
  Branches       1772     1772           
=========================================
  Hits           7607     7607           
  Misses          561      561           
  Partials        933      933           
Impacted Files Coverage Δ
...ab/arturbosch/detekt/core/config/ValidateConfig.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0aed91...6421e90. Read the comment docs.

@BraisGabin BraisGabin added this to the 1.19.0 milestone Sep 13, 2021
@BraisGabin BraisGabin merged commit b4c095e into main Sep 13, 2021
@BraisGabin BraisGabin deleted the refactor-validate-config branch September 13, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants