Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.5.31 #4113

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Kotlin 1.5.31 #4113

merged 2 commits into from
Sep 20, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Sep 19, 2021

Updated Kotlin artifacts have been released, but this should be held back until the official release announcement.

@3flex 3flex added the blocked label Sep 19, 2021
@3flex 3flex mentioned this pull request Sep 19, 2021
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #4113 (3a67028) into main (cbdb460) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4113      +/-   ##
============================================
- Coverage     83.51%   83.44%   -0.07%     
  Complexity     3186     3186              
============================================
  Files           461      461              
  Lines          9095     9093       -2     
  Branches       1768     1769       +1     
============================================
- Hits           7596     7588       -8     
- Misses          570      571       +1     
- Partials        929      934       +5     
Impacted Files Coverage Δ
...itlab/arturbosch/detekt/core/extensions/Loading.kt 20.00% <ø> (ø)
...gitlab/arturbosch/detekt/core/tooling/Lifecycle.kt 100.00% <ø> (ø)
...in/io/gitlab/arturbosch/detekt/api/SingleAssign.kt 80.00% <0.00%> (-20.00%) ⬇️
...tekt/rules/exceptions/TooGenericExceptionThrown.kt 54.54% <0.00%> (-4.55%) ⬇️
...etekt/rules/style/FunctionOnlyReturningConstant.kt 94.87% <0.00%> (-2.57%) ⬇️
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 82.92% <0.00%> (-2.44%) ⬇️
...bosch/detekt/rules/complexity/LongParameterList.kt 84.44% <0.00%> (-2.23%) ⬇️
...b/arturbosch/detekt/rules/complexity/LongMethod.kt 87.50% <0.00%> (-2.09%) ⬇️
...ekt/generator/collection/ConfigurationCollector.kt 74.19% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdb460...3a67028. Read the comment docs.

@@ -16,6 +17,7 @@ import org.spekframework.spek2.Spek
import org.spekframework.spek2.style.specification.describe
import java.nio.file.Paths

@OptIn(UnstableApi::class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that we were using now is it unestable? What is it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See link in second commit message: https://kotlinlang.org/docs/whatsnew1530.html#requiring-opt-in-on-implicit-usages-of-experimental-apis

In Kotlin 1.5.30, the compiler treats any declaration that has an experimental type in the signature as experimental. Namely, it requires opt-in even for implicit usages of an experimental API.

So the OptIn annotation is required in a few new places because there is usage of something annotated with @UnstableApi, in this case SarifReportOutput.init which has SetupContext in its signature, which itself is annotated with UnstableApi.

@BraisGabin
Copy link
Member

Why is this blocked?

@3flex
Copy link
Member Author

3flex commented Sep 19, 2021

Why is this blocked?

Waiting until the official release. The IntelliJ plugin 1.5.31 for example is not yet out so it seems premature to merge until the full Kotlin release process has completed.

@3flex 3flex added notable changes Marker for notable changes in the changelog dependencies Pull requests that update a dependency file and removed notable changes Marker for notable changes in the changelog blocked labels Sep 19, 2021
@3flex 3flex added this to the 1.19.0 milestone Sep 20, 2021
@3flex
Copy link
Member Author

3flex commented Sep 20, 2021

https://github.com/JetBrains/kotlin/releases/tag/v1.5.31

@3flex 3flex merged commit 34f8717 into detekt:main Sep 20, 2021
@3flex 3flex deleted the kotlin-1.5.31 branch September 20, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants