-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin 1.5.31 #4113
Kotlin 1.5.31 #4113
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4113 +/- ##
============================================
- Coverage 83.51% 83.44% -0.07%
Complexity 3186 3186
============================================
Files 461 461
Lines 9095 9093 -2
Branches 1768 1769 +1
============================================
- Hits 7596 7588 -8
- Misses 570 571 +1
- Partials 929 934 +5
Continue to review full report at Codecov.
|
@@ -16,6 +17,7 @@ import org.spekframework.spek2.Spek | |||
import org.spekframework.spek2.style.specification.describe | |||
import java.nio.file.Paths | |||
|
|||
@OptIn(UnstableApi::class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that we were using now is it unestable? What is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See link in second commit message: https://kotlinlang.org/docs/whatsnew1530.html#requiring-opt-in-on-implicit-usages-of-experimental-apis
In Kotlin 1.5.30, the compiler treats any declaration that has an experimental type in the signature as experimental. Namely, it requires opt-in even for implicit usages of an experimental API.
So the OptIn annotation is required in a few new places because there is usage of something annotated with @UnstableApi
, in this case SarifReportOutput.init
which has SetupContext
in its signature, which itself is annotated with UnstableApi
.
Why is this blocked? |
Waiting until the official release. The IntelliJ plugin 1.5.31 for example is not yet out so it seems premature to merge until the full Kotlin release process has completed. |
Updated Kotlin artifacts have been released, but this should be held back until the official release announcement.