Don't unnecessarily propogate opt-in requirement#4116
Merged
3flex merged 1 commit intodetekt:mainfrom Sep 20, 2021
Merged
Conversation
Opt-in doesn't need to be propogated in test code, or in detekt-core which is not public API. https://kotlinlang.org/docs/opt-in-requirements.html#non-propagating-opt-in > In modules that don't expose their own API, such as applications, you can > opt in to using APIs without propagating the opt-in requirement to your > code. In this case, mark your declaration with @OptIn passing the opt-in > requirement annotation as its argument.
Codecov Report
@@ Coverage Diff @@
## main #4116 +/- ##
=========================================
Coverage 83.51% 83.51%
Complexity 3186 3186
=========================================
Files 461 461
Lines 9095 9095
Branches 1768 1768
=========================================
Hits 7596 7596
Misses 570 570
Partials 929 929
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Sep 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in doesn't need to be propogated in test code, or in detekt-core which is not public API.
https://kotlinlang.org/docs/opt-in-requirements.html#non-propagating-opt-in