Disable UnsafeCallOnNullableType on tests#4123
Merged
chao2zhang merged 2 commits intomainfrom Sep 28, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4123 +/- ##
=========================================
Coverage 83.44% 83.45%
Complexity 3186 3186
=========================================
Files 461 461
Lines 9093 9094 +1
Branches 1769 1769
=========================================
+ Hits 7588 7589 +1
Misses 571 571
Partials 934 934
Continue to review full report at Codecov.
|
cortinico
approved these changes
Sep 23, 2021
chao2zhang
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
UnsafeCallOnNullableTypeon tests. The use of!!is a type of assertion. It should not be a problem to use it in your tests.Fixes #4119
Closes #4118