Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split InvalidPackageDeclaration to create MissingPackageDeclaration #4149

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Oct 2, 2021

InvalidPackageDeclaration was doing two different things. With this PR we split that responsability in two different rules.

I created the new rule MissingPackageDeclaration inside the error prone rule set, do you agree?

Closes #3957

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #4149 (7057bfc) into main (f12697d) will increase coverage by 0.01%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4149      +/-   ##
============================================
+ Coverage     83.44%   83.46%   +0.01%     
- Complexity     3177     3179       +2     
============================================
  Files           465      466       +1     
  Lines          9104     9114      +10     
  Branches       1775     1775              
============================================
+ Hits           7597     7607      +10     
  Misses          572      572              
  Partials        935      935              
Impacted Files Coverage Δ
...h/detekt/rules/naming/InvalidPackageDeclaration.kt 96.15% <87.50%> (+3.29%) ⬆️
...sch/detekt/rules/bugs/MissingPackageDeclaration.kt 90.90% <90.90%> (ø)
...etekt/generator/printer/defaultconfig/Exclusion.kt 96.77% <100.00%> (ø)
...turbosch/detekt/rules/bugs/PotentialBugProvider.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12697d...7057bfc. Read the comment docs.

@chao2zhang chao2zhang added this to the 1.19.0 milestone Oct 3, 2021
@cortinico cortinico merged commit 63dc501 into main Oct 15, 2021
@cortinico cortinico deleted the issue-3957 branch October 15, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: MissingPackageDeclaration
4 participants