Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for MagicNumber #4152

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

chao2zhang
Copy link
Member

This addresses #4080 by verifying that ignorePropertyDeclaration, ignoreCompanionObjectPropertyDeclaration, ignoreNamedArgument are working if a magic number is used inside a functional call.

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #4152 (4533b69) into main (f12697d) will not change coverage.
The diff coverage is n/a.

❗ Current head 4533b69 differs from pull request most recent head 1a73425. Consider uploading reports for the commit 1a73425 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4152   +/-   ##
=========================================
  Coverage     83.44%   83.44%           
  Complexity     3177     3177           
=========================================
  Files           465      465           
  Lines          9104     9104           
  Branches       1775     1775           
=========================================
  Hits           7597     7597           
  Misses          572      572           
  Partials        935      935           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12697d...1a73425. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻👏🏻

@chao2zhang chao2zhang added this to the 1.19.0 milestone Oct 3, 2021
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Oct 4, 2021
@BraisGabin BraisGabin merged commit 096ef5f into detekt:main Oct 4, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants