Skip to content

Update detekt-formatting default rules #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2021
Merged

Conversation

3flex
Copy link
Member

@3flex 3flex commented Oct 12, 2021

Fixes #4167

@3flex 3flex added notable changes Marker for notable changes in the changelog formatting labels Oct 12, 2021
@3flex 3flex added this to the 1.19.0 milestone Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #4179 (e6a216e) into main (3382394) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e6a216e differs from pull request most recent head e8f28af. Consider uploading reports for the commit e8f28af to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4179   +/-   ##
=========================================
  Coverage     83.44%   83.44%           
+ Complexity     3191     3190    -1     
=========================================
  Files           465      465           
  Lines          9119     9119           
  Branches       1779     1779           
=========================================
  Hits           7609     7609           
  Misses          572      572           
  Partials        938      938           
Impacted Files Coverage Δ
...bosch/detekt/formatting/wrappers/ImportOrdering.kt 100.00% <ø> (ø)
...turbosch/detekt/formatting/wrappers/Indentation.kt 100.00% <ø> (ø)
...osch/detekt/formatting/wrappers/MultiLineIfElse.kt 100.00% <ø> (ø)
...turbosch/detekt/formatting/wrappers/PackageName.kt 100.00% <ø> (ø)
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt 97.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3382394...e8f28af. Read the comment docs.

3flex added 5 commits October 13, 2021 13:06
This is a ktlint-ruleset-standard rule, run by ktlint by default.
This is a ktlint-ruleset-standard rule, run by ktlint by default.
This is a ktlint-ruleset-experimental rule, not run by ktlint by default.
This is a ktlint-ruleset-experimental rule, not run by ktlint by default.
Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably worth calling out in the top slot of release notes, since we disable two rules by default.

@3flex 3flex merged commit e0fa7a3 into detekt:main Oct 16, 2021
@3flex 3flex deleted the ktlint-default branch November 19, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detekt-formatting default enabled rules differ from ktlint defaults
3 participants