Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codecov GitHub Action to upload coverage #4184

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

3flex
Copy link
Member

@3flex 3flex commented Oct 13, 2021

Fixes #4183

@3flex 3flex added the housekeeping Marker for housekeeping tasks and refactorings label Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #4184 (cdd3909) into main (eb62de7) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4184      +/-   ##
============================================
+ Coverage     83.55%   84.10%   +0.54%     
- Complexity     3195     3197       +2     
============================================
  Files           466      466              
  Lines          9109    10089     +980     
  Branches       1773     1773              
============================================
+ Hits           7611     8485     +874     
- Misses          567      673     +106     
  Partials        931      931              
Impacted Files Coverage Δ
...b/detekt/tooling/internal/DefaultAnalysisResult.kt 87.50% <0.00%> (-12.50%) ⬇️
...lin/io/gitlab/arturbosch/detekt/api/ConfigAware.kt 50.00% <0.00%> (-10.00%) ⬇️
...b/arturbosch/detekt/rules/style/FileParsingRule.kt 92.30% <0.00%> (-7.70%) ⬇️
...bosch/detekt/rules/style/UnnecessaryInheritance.kt 92.85% <0.00%> (-7.15%) ⬇️
...ch/detekt/rules/coroutines/GlobalCoroutineUsage.kt 83.33% <0.00%> (-6.67%) ⬇️
...ab/arturbosch/detekt/rules/bugs/UnreachableCode.kt 93.75% <0.00%> (-6.25%) ⬇️
...rturbosch/detekt/rules/naming/FunctionMaxLength.kt 93.75% <0.00%> (-6.25%) ⬇️
...rturbosch/detekt/rules/naming/FunctionMinLength.kt 93.75% <0.00%> (-6.25%) ⬇️
...rturbosch/detekt/rules/naming/VariableMaxLength.kt 93.75% <0.00%> (-6.25%) ⬇️
.../arturbosch/detekt/core/tooling/ParsingStrategy.kt 27.27% <0.00%> (-6.07%) ⬇️
... and 313 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb62de7...cdd3909. Read the comment docs.

@3flex
Copy link
Member Author

3flex commented Oct 13, 2021

Merging #4184 (cdd3909) into main (eb62de7) will increase coverage by 0.54%.

This is a little surprising - it might have happened due to a bug in the old uploader that's fixed in the new one, or a bug in the new uploader... but as the Bash uploader is definitely deprecated and needs to be removed I don't think this should be a blocker, as we can consider Codecov and the uploader to be a black box. I did a quick search for info about behaviour changes in the new uploader but didn't uncover anything.

@chao2zhang chao2zhang added this to the 1.19.0 milestone Oct 13, 2021
@3flex 3flex merged commit 60ee0b7 into main Oct 13, 2021
@3flex 3flex deleted the new-codecov-uploader branch October 13, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to new Codecov uploader
2 participants