Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report NewLineAtEndOfFile source location at end of file #4187

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Oct 16, 2021

Fixes #4181

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #4187 (ed9dde6) into main (e0fa7a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4187   +/-   ##
=========================================
  Coverage     84.12%   84.13%           
  Complexity     3201     3201           
=========================================
  Files           467      467           
  Lines         10102    10108    +6     
  Branches       1773     1773           
=========================================
+ Hits           8498     8504    +6     
  Misses          673      673           
  Partials        931      931           
Impacted Files Coverage Δ
...kotlin/io/gitlab/arturbosch/detekt/api/Location.kt 81.48% <ø> (ø)
...rturbosch/detekt/rules/style/NewLineAtEndOfFile.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0fa7a3...ed9dde6. Read the comment docs.

@BraisGabin BraisGabin added this to the 1.19.0 milestone Oct 16, 2021
@BraisGabin BraisGabin merged commit 75bec4a into detekt:main Oct 16, 2021
@3flex 3flex deleted the 4181-fix branch October 16, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewLineAtEndOfFile reports the wrong position
3 participants