Fix baserule import in tests #4189
Conversation
| @@ -37,7 +37,6 @@ public final class io/github/detekt/test/utils/NullPrintStream : java/io/PrintSt | |||
| public final class io/github/detekt/test/utils/ResourcesKt { | |||
| public static final fun readResourceContent (Ljava/lang/String;)Ljava/lang/String; | |||
| public static final fun resource (Ljava/lang/String;)Ljava/net/URI; | |||
| public static final fun resourceAsFile (Ljava/lang/String;)Ljava/io/File; | |||
There was a problem hiding this comment.
I'm actually surprised that this happened 🤔 Was the task failing locally?
There was a problem hiding this comment.
Yes it was. That's why I ran the task apiDump. Should that change be excluded from this PR?
There was a problem hiding this comment.
Nope that's fine 👍 I'm more wondering how comes that this change was not captured by the CI at #4157 I'll look into it.
There was a problem hiding this comment.
Oh seems like we effectively broke the CI. This PR fixes it 🚀 Thanks for doing it!
Codecov Report
@@ Coverage Diff @@
## main #4189 +/- ##
=========================================
Coverage 84.13% 84.13%
Complexity 3201 3201
=========================================
Files 467 467
Lines 10108 10108
Branches 1773 1773
=========================================
Hits 8504 8504
Misses 673 673
Partials 931 931
Continue to review full report at Codecov.
|
#4157 changed the location of
BaseRule, but missed an import in a test package.This PR fixes it.