Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct --jvm-target values when using --help flag #4195

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Oct 21, 2021

Fixes #3551

Also removes duplication of output for --language-version flag which shows possible values dynamically thanks to proper toString override on LanguageVersion.

Old:

    --jvm-target
      EXPERIMENTAL: Target version of the generated JVM bytecode that was 
      generated during compilation and is now being used for type resolution 
      (1.6, 1.8, 9, 10, 11, 12, 13, 14, 15 or 16)
      Default: JVM_1_8
      Possible Values: [JVM_1_6, JVM_1_8, JVM_9, JVM_10, JVM_11, JVM_12, JVM_13, JVM_14, JVM_15, JVM_16]
    --language-version
      EXPERIMENTAL: Compatibility mode for Kotlin language version X.Y, 
      reports errors for all language features that came out later (1.0, 1.1, 
      1.2, 1.3, 1.4 or 1.5)
      Possible Values: [1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7]

New:

    --jvm-target
      EXPERIMENTAL: Target version of the generated JVM bytecode that was 
      generated during compilation and is now being used for type resolution 
      (1.6, 1.8, 9, 10, 11, 12, 13, 14, 15 or 16)
      Default: 1.8
    --language-version
      EXPERIMENTAL: Compatibility mode for Kotlin language version X.Y, 
      reports errors for all language features that came out later
      Possible Values: [1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7]

@3flex 3flex added the cli label Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #4195 (ad8efc8) into main (c848341) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4195      +/-   ##
============================================
+ Coverage     84.19%   84.20%   +0.01%     
  Complexity     3233     3233              
============================================
  Files           468      468              
  Lines         10185    10183       -2     
  Branches       1786     1785       -1     
============================================
  Hits           8575     8575              
+ Misses          671      669       -2     
  Partials        939      939              
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/cli/ArgumentConverters.kt 75.00% <ø> (+5.76%) ⬆️
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <100.00%> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 90.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c848341...ad8efc8. Read the comment docs.

@chao2zhang chao2zhang added this to the 1.19.0 milestone Oct 24, 2021
@3flex 3flex merged commit ea00969 into detekt:main Oct 26, 2021
@3flex 3flex deleted the 3551-fix branch November 19, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cli argument "jvm-target" does not support values mentioned in the documentation
3 participants