-
-
Notifications
You must be signed in to change notification settings - Fork 803
Add tests for merging reports #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4199 +/- ##
============================================
- Coverage 84.33% 84.27% -0.07%
- Complexity 3243 3249 +6
============================================
Files 470 471 +1
Lines 10227 10261 +34
Branches 1789 1805 +16
============================================
+ Hits 8625 8647 +22
- Misses 663 664 +1
- Partials 939 950 +11
Continue to review full report at Codecov.
|
It looks like we have a solution for Java 17 failures - fluttercommunity/flutter_workmanager#287 (comment). I am unsure if this is the right fix. |
I can't guarantee but this problem will possibly go away with Gradle 7.3. Gradle 7.2 doesn't support Java 17. You might try updating the wrapper to 7.3-rc-3 to see if this issue is resolved. |
detekt-gradle-plugin/src/test/kotlin/io/gitlab/arturbosch/detekt/report/ReportMergeSpec.kt
Outdated
Show resolved
Hide resolved
I would vote to move the tests back to Java 16 then. Until gradle supports Java 17. |
I think this can be left on |
This PR is now unblocked since Gradle 7.3 supports Java 17 officially |
You might need to check and force push again, the diff is now empty... |
This PR adds tests for #4192. The problem seems to be happening for Detekt/Android, but not Detekt/Jvm.