Skip to content

Add tests for merging reports #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2021
Merged

Add tests for merging reports #4199

merged 3 commits into from
Nov 13, 2021

Conversation

chao2zhang
Copy link
Member

This PR adds tests for #4192. The problem seems to be happening for Detekt/Android, but not Detekt/Jvm.

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #4199 (300417c) into main (8c1d992) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 300417c differs from pull request most recent head ce9a49d. Consider uploading reports for the commit ce9a49d to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4199      +/-   ##
============================================
- Coverage     84.33%   84.27%   -0.07%     
- Complexity     3243     3249       +6     
============================================
  Files           470      471       +1     
  Lines         10227    10261      +34     
  Branches       1789     1805      +16     
============================================
+ Hits           8625     8647      +22     
- Misses          663      664       +1     
- Partials        939      950      +11     
Impacted Files Coverage Δ
...les/style/ExplicitCollectionElementAccessMethod.kt 62.06% <0.00%> (-6.90%) ⬇️
...tlab/arturbosch/detekt/rules/KtBinaryExpression.kt 0.00% <0.00%> (ø)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <0.00%> (ø)
...ch/detekt/rules/style/UseAnyOrNoneInsteadOfFind.kt 76.00% <0.00%> (ø)
...gitlab/arturbosch/detekt/rules/KtCallExpression.kt 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1d992...ce9a49d. Read the comment docs.

@chao2zhang
Copy link
Member Author

It looks like we have a solution for Java 17 failures - fluttercommunity/flutter_workmanager#287 (comment). I am unsure if this is the right fix.

@3flex
Copy link
Member

3flex commented Oct 27, 2021

Java 17 failures

I can't guarantee but this problem will possibly go away with Gradle 7.3. Gradle 7.2 doesn't support Java 17. You might try updating the wrapper to 7.3-rc-3 to see if this issue is resolved.

@BraisGabin
Copy link
Member

I can't guarantee but this problem will possibly go away with Gradle 7.3. Gradle 7.2 doesn't support Java 17.

I would vote to move the tests back to Java 16 then. Until gradle supports Java 17.

@cortinico
Copy link
Member

I would vote to move the tests back to Java 16 then. Until gradle supports Java 17.

I think this can be left on blocked till Gradle 7.3 is out which should be really soon (they're on RC)

@chao2zhang
Copy link
Member Author

This PR is now unblocked since Gradle 7.3 supports Java 17 officially

@3flex
Copy link
Member

3flex commented Nov 10, 2021

You might need to check and force push again, the diff is now empty...

@cortinico cortinico added this to the 1.19.0 milestone Nov 10, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Nov 10, 2021
@chao2zhang chao2zhang marked this pull request as draft November 10, 2021 17:26
@chao2zhang chao2zhang marked this pull request as ready for review November 11, 2021 17:37
@chao2zhang chao2zhang merged commit 78e6d83 into detekt:main Nov 13, 2021
@chao2zhang chao2zhang deleted the merge branch November 13, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants